Loading...
Important Notice - Forums is archived

To simplify things and help our users to be more productive, we have archived the current forum and focus our efforts on helping developers on Stack Overflow. You can post new questions on Stack Overflow or join our Discord channel.

Product icon
TUTORIAL

Vaadin lets you build secure, UX-first PWAs entirely in Java.
Free ebook & tutorial.

Did 7.5.1 break Layouts?

Iyad Nahas
7 years ago Jul 09, 2015 8:49pm

Updating from 7.5.0 to 7.5.1 causes weird sizing and scrolling issues. 

For one thing, Valo menus now always shows a scroll bar. For another some CustomLayouts are now sized improperly and their contents are overflowing over other components. 

To verify it's a 7.5.1 issue I rebuilt the Quicktickets-dashboard demo application under 7.5.1 and sure enough I'm seeing the same behavior.
 

Alex Odesser
7 years ago Jul 10, 2015 10:57am
Ilia Motornyi
7 years ago Jul 10, 2015 2:55pm
Iyad Nahas
7 years ago Jul 10, 2015 3:52pm
Artur Signell
7 years ago Jul 10, 2015 6:31pm

There was a small change in 7.5.1 to make handling of nested invalid layouts more consistent with non-nested invalid layouts (invalid layout == component with % size inside parent with undefined size).

This is what you can see in the quicktickets demo currently also, the code is wrong (part of the menu is a csslayout set to 100% height, which is too high -> causes scrolbars). The fix for that is to fix the incorrect code in the demo. Previously the 100% height happened to be changed to undefined height, which is what it should have been set to in the code -> no scrollbars. 

I suspect you have something similar in your code, which has happened to work the way you have expected before.

Jose Luis Valencia
7 years ago Jul 10, 2015 7:11pm
Artur Signell
7 years ago Jul 10, 2015 7:20pm
Jose Luis Valencia
7 years ago Jul 10, 2015 7:27pm
Alexander Wagner
7 years ago Jul 21, 2015 10:42am

Another thing that (probably) broke with 7.5.1:

If you put a Grid on a SplitPanel, in 7.5.1 the Grid will not be fully sized.
In 7.5.0 it works.

You can try this simple test case:

VerticalLayout vl = new VerticalLayout();
vl.setSizeFull();
HorizontalSplitPanel hp = new HorizontalSplitPanel();
hp.setSizeFull();
Grid g = new Grid();
g.setSizeFull();
Column c1 = g.addColumn("1");
c1.setMaximumWidth(100);
g.addColumn("2");
g.addRow("v1", "v2");
hp.setFirstComponent(g);
vl.addComponent(hp);
setContent(vl);

Artur Signell
7 years ago Jul 27, 2015 6:37am
Alexander Wagner
7 years ago Jul 27, 2015 7:09am
Artur Signell
7 years ago Jul 27, 2015 7:41am
Artur Signell
7 years ago Jul 27, 2015 10:54am
Alexander Wagner
7 years ago Jul 27, 2015 11:32am