Menubar type issue in 24.7.0 for hilla?

Hilla
1

I am getting type error in menubar onItemSelected method

I have menubar like this

<MenuBar
      items={[
          {
              text: 'View',
              children: [
                  {
                      text: 'Normal',
                      theme: '',
                      checked: selectedItem.value === '',
                  },
                  {
                      text: 'Compact',
                      theme: 'compact',
                      checked: selectedItem.value === 'compact',
                  }
              ],
          },
      ]}
      onItemSelected={(e) => {
          selectedItem.value = e.detail.value.theme as string;
      }}
  />

image
image879×814 45.6 KB

But code runs perfectly fine. In console log i see correct e.detail.value

2

Can confirm that is a bug in the new release. I’ve created a PR with a fix: fix: provide base menu item properties in item selected event by sissbruecker · Pull Request #303 · vaadin/react-components · GitHub

For now, as a workaround, you’ll have to add a cast somewhere, for example:

<MenuBar items={[...] as MenuBarItem[]} />
1 Like