Local builds of Vaadin-Spreadsheet addon

Flow
1

The project readme.md says:

“To build and install the project into the local repository run
mvn install
 in the root directory”

However, this fails on a local clone, because many TestBench based tests specify an explicit remote host/grid to run on with

@RunOnHub(“tb3-hub.intra.itmill.com”)

which of course is not publically available :slight_smile:

How are we supposed to build and test locally, so we can submit well-tested patches via GitHub pull requests?

Even when I add a hosts entry to map this name to 127.0.0.1 I still get tests failing with:

org.openqa.selenium.remote.UnreachableBrowserException: Could not start a new session. Possible causes are invalid address of the remote server or browser start-up failure.

due to “connection refused” - do I need to start Jetty manually before running
mvn install
?

2

Hi Greg,

You’re right, “tb3-hub.intra.itmill.com” is an internal TestBench Grid that we use for running tests in all supported browsers.

If you change the annotation for @RunLocally you can run the tests locally, by default it will use Firefox iirc, but it has parameters to set browser. Running all tests locally will take some time, and local testing with screenshot tests (as spreadsheet has) is not so reliable as rendering is platform dependent. I would recomend to use @RunLocally for new or specific tests (remember not to include the annotation in the Pull Request changes).

Also all tests are run for each Pull Request, so if there’s something you missed there will be validation for your changes, if validation fails you should be able to see the details for the failure.

Thanks!