Hi! First I wanna say that this is a good and util addon. Thank you for creating this.
I’ve found a bug. Let’s say we have this:
pagination.setItemsPerPage(10, 20, 50, 100);
And selected by default the value 20.
If we will change value from 20 to 10 in the comboBox, then going to the last page, will show a validation error in UI.
Wrong number page, caused by, giving rigidly a validator for the TextField, only from the component initialization from method: createPageFields();
So I’ve fixed it, creating a method:
private IntegerRangeValidator buildIntegerRangeValidator() {
return new IntegerRangeValidator("Wrong page number", 0, this.paginationResource.totalPage());
}
And then call it in 2 places:
First in the method: createPageFields()
this.currentPageTextField.addValidator(buildIntegerRangeValidator());
and second, in the listener of the combobox, from the method:
reateItemsPerPage() {
…
this.itemsPerPageSelect.addValueChangeListener((event) → {
int pageSize = (Integer)event.getProperty().getValue();
if (pageSize != this.paginationResource.limit()) {
this.paginationResource.setLimit((Integer)event.getProperty().getValue());
this.paginationResource.setPage(1);
this.firePagedChangedEvent();
currentPageTextField.removeAllValidators();
currentPageTextField.addValidator(buildIntegerRangeValidator());
}
});
…
}