Ok, this is kind of a weird question, but I need to change a current V7 add-on ( the excellent Exporter add-on ) and fix a few issues I am having. These issues would only impact Vaadin 7 maybe Vaadin 8 ( not sure if Vaadin 8 version has the problems I am fixing or not ). Obviously, the V7 branch is not being maintained anymore, so I expect I will need to add it to the directory. Was wondering how to do it?
Yes, I know this is strange. My eventual plan is to make a compatibility mode for this add-on so I can more slowly convert my MP + Vaadin 7 app from Vaadin 7 Exporter to Flow Exporter, and I bet someone else out there is having the same problem as me with converting from Vaadin 7 to Vaadin 10+, so being able to add a Vaadin 7 add-on would also help them.
Yes, I did submit issues, but since what I am asking for is in a stale branch for an outdated version of Vaadin, I figure I might need to submit the add-on to the directory.
Hi Anthony, good to hear that you are using this addon actively. The v7 version currently is not actively maintained, but I can still publish new versions if needed.
If you are fixing some issues, I think one good way would be that you make some pull request(s) to the v7 branch, I can merge them and publish new versions.
I did add some issues and my first pull request yesterday. I am currently stress testing it in my app, but the changes worked with the demo app. This is my first time contributing, and I am no git expert, so I might have done it wrong, but hopefully you can see the issues and pull request.
Hi Anthony, I just did a quick review, in general it looks really nice, thanks a lot for the contribution. I added a few comments, maybe you can take look?
Sorry, maybe I am missing something, but I see no comments anyplace. I am new to contributing to open source ( or even a git project with multiple contributers ), so maybe I am missing something? I checked the [pull]
(https://github.com/haiwan/Exporter/pull/32) and the [issue]
(https://github.com/haiwan/Exporter/issues/31), saw no comments in either place. PLease clarify.
Thanks. Just so you know, I will probably be making a few other contributions. Don’t have time right now, but I will be doing the following within the coming months:
Some Grid helper methods. Mainly convenience methods for Vaadin 7, but not required ( since I can just sub-class and get the behavior I want, which is the code I will be copying ), but might give you ideas for Flow. The only special thing I do in my code that the Flow version may not support is allow for Grid’s multiple column headings. No issue created yet.