Vite/Rollup build error after upgrading to 24.1.8

Flow
21

Not sure why this would be the problem though. It looks like its creating chunks with imports inside a function, which is definitely invalid JS

22

@quirky-zebra Unfortunately, reverting to old code didn’t fix the problem

23

Damn… did you upgrade from 24.1.7 or earlier?

24

From 24.1.7

25

https://github.com/vaadin/flow/pull/17522 was in between 24.1.7->8 as well

26

Tried reverting it too

27

Hopefully Gradle is using my classpath overrides

28

:confused: not good… those are the only things that come to mind… @sanguine-whale do you happen to know something else that could have caused this regression?

29

Tried running Vite manually (./node_modules/vite/bin/vite.js build). Same error.

30

Just in case: you don’t use nodejs 20.6?

31

18.17.1

32

Good :grimacing: just wanted to rule out anything

33

I dont understand why chunks would output this way

34

Shouldn’t they all be in the format:

// imports
// injectGlobalCss
35

https://github.com/vaadin/flow/issues/17573

36

Looks like a broken JS code generator somewhere, indeed the above JS looks incorrect. Let me check the updates between 24.1.7 and 24.1.8

37

@astonishing-kookaburra could you please try to use Vaadin 24.1.8 with Flow 24.1.9 ?

38

So you need

39
com.vaadin flow-bom 24.1.9 pom import com.vaadin vaadin-bom ${vaadin.version} pom import
40

OMG, I think I found the error.