no manifest found in tpt-1.2.0.jar

[Dmitri (Dmitri Livotov)]

Hi !

When trying to upload a new addon version, directory responds with “no manifest found in tpt-1.2.0.jar”. Coud anyone give me a glue what is wrong ? The zip addon structure seems to be in conformance with documents, both manifests are present and contains the same version number.

The failing addon is attached.

Thanks a lot !

Dmitri
11599.zip (743 KB)

[Dmitri (Dmitri Livotov)]

Any hit still actual

[Teemu (Teemu Pöntelin)]

Hi Dmitri,

the META-INF/MANIFEST.MF does seem to be included in the JAR file. However, I would guess the problem is that it’s not the first entry in the JAR file.

Wikipedia page on
JAR file
says:

Computer users can create or extract JAR files using the jar command that comes with a JDK. They can also use zip tools to do so; however, caution should be exercised as to the order of entries in the zip file headers as the manifest likely needs to be first.

The code that Directory uses to access the manifest uses standard Java library methods in a similar fashion as the code below:

JarInputStream jis = new JarInputStream(new FileInputStream(file));
Manifest manifest = jis.getManifest();

The code above actually results in the
manifest
variable being
null
if run with the tpt-1.2.0.jar found inside the zip archive.

[Henri2 (Henri Sara)]

@Teemu Pöntelin

the META-INF/MANIFEST.MF does seem to be included in the JAR file. However, I would guess the problem is that it’s not the first entry in the JAR file.

This has at least caused some problems in the past. The “jar” program automatically puts the manifest as the first entry, but “zip” does not.

[Dmitri (Dmitri Livotov)]

Teemu, Henri, thanks a lot !
Was offline for a while due to load but seems to be online now -)

Yep, I forgot all this jar troubles, thanks for pointing. Will repack using jar.

P.S. Actually, we’re using truezip for a long time for any zip/jar related operations and it is a great helper for hiding all low level stuff in comparison to built-in zip api.