timeline addon weird coding

Vaadin 6 / 7 / 8 Framework UI
1

In Timeline.setGraphValuePropertyId there’s:

if (clazz == Integer.class || clazz == Double.class
                    || clazz == Float.class) {
                ds.setValueProperty(id);
            } else {
                throw new IllegalArgumentException(
                        "The value property must be numeric.");
            }

Any reason why is not:
if (Number.class.isAssignableFrom(clazz)), or something similar, with emphasys on Number, because I wanted to use a Short directly, but it may be a Byte sometimes as well

2

I don’t see any reason why it could not be
Number.class.isAssignableFrom(clazz)
.

Please create a
ticket
 for it so fixing this is not forgotten.

3

This has now been fixed and the fix is now available as a
Timeline Custom Build
 for Pro users. The fix will be included in the next maintenance release.

4

And the moral is…it’s bad practice to not pay devs, bad programming practice in return that is :stuck_out_tongue: