Problem with layout after upgrading to 7.3

Hello,
I’m trying to upgrade my application from Reindeer 7.2.7 to Valo 7.3.8. Unfortunately some of my windows “lose” (they are outside the window - see screanshots: yellow button from DebugWindow is red field below window) buttons.

My code looks as follows:

    protected void buildMainLayout() {
        center();
//        setClosable(false);
        //http://dev.vaadin.com/ticket/11319
        setModal(!UI.getCurrent().getPage().getWebBrowser().isIE());
        
        VerticalLayout mainLayout = new VerticalLayout();
        mainLayout.setMargin(true);
        mainLayout.setSpacing(true);
        
        viewer = createViewer();
        viewer.setSizeFull();
        mainLayout.addComponent(viewer);
        mainLayout.setExpandRatio(viewer, 1);
       
        error = new Label();
        error.setContentMode(ContentMode.HTML);
        error.addStyleName("error");
        error.setWidth("100%");
        mainLayout.addComponent(error);

        warning = new Label();
        warning.setContentMode(ContentMode.HTML);
        warning.addStyleName("warning");
        warning.setWidth("100%");
        mainLayout.addComponent(warning);

        info = new Label();
        info.setContentMode(ContentMode.HTML);
        info.addStyleName("info");
        info.setWidth("100%");
        mainLayout.addComponent(info);

        Component buttonPannel = createButtons();
        mainLayout.addComponent(buttonPannel);
        buttonPannel.setWidth("100%");
        mainLayout.setSizeFull();
        setContent(mainLayout);
    }
    protected AbstractComponentContainer createViewer() {
            VerticalLayout layout = new VerticalLayout();
            layout.setSpacing(true);
            layout.addComponent(new Label("Please write type to reload:"));
            packageField = new ComboBox("Package:");
        constantField = new TextField("FRFXPA type:");
        constantField.addValueChangeListener(clearError);
        layout.addComponent(packageField);
        layout.addComponent(constantField);
        return layout;

[/code]
] }
[/code]

    protected Component createButtons() {
        HorizontalLayout layout = new HorizontalLayout();
        layout.setSpacing(true);
        Button ok = new Button(Utils.getMessage("OK_LBL", WindowWithButtons.class));              ok.addClickListener(new ClickListener() {
            
            private static final long serialVersionUID = -453389644562270722L;

            @Override
            public void buttonClick(ClickEvent event) {
                okClick();
            }
        });
        ok.setWidth(7, Unit.EM);
        ok.setClickShortcut(KeyCode.ENTER);
        ok.addStyleName("primary");
        ok.setId(getClass().getSimpleName() + ".OK");
        layout.addComponent(ok);
        layout.setComponentAlignment(ok, Alignment.MIDDLE_LEFT);
Button cancel = new Button(Utils.getMessage("Cancel_LBL", WindowWithButtons.class));
        cancel.addClickListener(new ClickListener() {
            
            private static final long serialVersionUID = 2159086535591888257L;

            @Override
            public void buttonClick(ClickEvent event) {
                cancelClick();
            }
        });
        cancel.setWidth(7, Unit.EM);
        cancel.setClickShortcut(KeyCode.ESCAPE);
        cancel.setId(getClass().getSimpleName() + ".Cancel");
        layout.addComponent(cancel);
        layout.setComponentAlignment(cancel, Alignment.MIDDLE_RIGHT);
        return layout;
    }

Have you forgot to attach screenshots?

Seems they were lost during editation. Attached here.
18219.png
18220.png

Try removing this line:
viewer.setSizeFull();

What happens now?

No difference :frowning:

So, it turned out to be a bug in Valo, namely this one:
http://dev.vaadin.com/ticket/14234

As a workaround you can try to set those labels that are zero height to display: block; in CSS.

So add a style to your theme:
.error, .warning, .info { display: block; }

Or directly in Java code:
Page.getCurrent().getStyles().add(“.error, .warning, .info { display: block; }”);

Thank you. I’ll try it. It is only pity, that the issue won’t be fixed :frowning: