JPAContainer fork

Vaadin 6 / 7 / 8 Framework Data Binding
1

Hi all,

I’m using the JPAContainer, but as it is is not suitable for my needing, so i’v forked it and created my own version. Now i’d like to make it accessible to all.

I’ve pushed the code to
https://github.com/lelmarir/jpacontainer/commits/custom
.
The “master” branck is in sync with the svn repo, and
 the “custom” branch contain my modifications. (i’ve just realized that the main JPAContainer repo is the one on github, not svn. Now my repo is a true fork)

Some features:

  • enhanced extensibility (becouse i need to extend it…)
  • In filter ( container.addContainerFilter(Filters.in(“id”, Arrays.toList(new Object {1,2,3,5}));
  • implemented JPAContainerItemProperty.setReadOnly(true)
  • EntityItem.markAdDirty() to tell the container the entity has been manually modified and shoul be persisted
  • Nested commits (if during a commit, for whatever reason you call commit again, now it works)
  • and other minor fixes (see
    commits
    )

If someone is interested (other users or JPAContainer devs) i’ll be happy to help.

2

Would you be interested in contributing back to the official JPAContainer project?

If so, see the
Contributing Code
 page, send in a signed contribution agreement and push changes to our code review system as described on the page.

Please note that the review system does not support Github pull requests so the changes need to be submitted separately for review, ideally as independent changes based on the master branch as long as they don’t logically depend on each other. This would also make it easier to submit individual changes as soon as they pass review even if others require more review rounds.

Some of the changes might not be suitable for the official version (e.g. not sure about the alternate build system, though I haven’t really looked at it yet, or possible changes that are not backwards compatible) or might need more discussion, but most could probably make it in.

3

Would be really great if you’d push the

entityItem.markAsDirty()

changes to the official JPAContainer. That would probably help lots of users.

4

I’d like to contribute, but i need some help with the contribution agreement…

in the last page, what am i supposed to write in the “By” field ? (english is not my first language and i dont get this…)

5

I agree that it is a little unclear.

You can sign there and have your name in clear, title and date on the rows below.

6

Hi,
i’d like to contribute. I’ve sent the signed agreement to contribution@vaadin.com, but no replies till now.

7

The main responsible for receiving and processing contribution agreements is currently on a conference trip but should be back soon.
I’ll try to check with him if he has already received your agreement.

Could you also let me know which user account you are using in Gerrit so I can link it to your contribution agreement. You can e-mail me at firstname.lastname @ vaadin.com .