Is it a Bug in PropertyFormatter

Vaadin 6 / 7 / 8 Framework Data Binding
1

Hi,

a strange NPE forced me to have a look at the PropertyFormatter course code.
At line 120 I found the following code:


        if (isReadOnly() != readOnly) {
            fireReadOnlyStatusChange();
        }
        String newVal = toString();
        if ((prevValue == null && newVal != null)
                || [b]
!prevValue.equals(prevValue)
[/b]) {
            fireValueChange();
        }

I get a NPE because prevValue is null. I think the code in bold does not make sense and should rather be newVal.equals(prevValue).

What do you think ?

2

Seems like a bug to me. Created
#3177

3

Thanks, now I know where to post bugs :slight_smile:

Nicolas