Framed TabSheet bottom border behavior

Hi,

here’s a simple code fragment (
1st case
):

[code]
@Override
protected void init(VaadinRequest request) {
final VerticalLayout layout = new VerticalLayout();
layout.setMargin(true);
setContent(layout);

// Create the test tab
VerticalLayout tab = new VerticalLayout();
tab.setHeight("100px"); //*

TabSheet tabsheet = new TabSheet();
tabsheet.addStyleName(ValoTheme.TABSHEET_FRAMED);

tabsheet.addTab(tab, "Tab");

// tabsheet.setSizeFull();
layout.addComponent(tabsheet);

layout.setSizeFull();

}
[/code]The result (attached "
proper_border.png
") shows TabSheet with an absolutely proper border.

For the
2nd case
line 15 (
// tabsheet.setSizeFull()
) gets uncommented. The goal is to make the
tabsheet
fill all the available space within the
layout
. And you get the attached "
improper_border.png
" result.
Everything is OK here, and works as it was expected, except for the bottom border. Looks like it disappears for some reason.


*Line 9 (tab.setHeight(“100px”)) has no effect for the 2nd case, and could be easily removed; it was needed only for the 1st
case to show the proper tabsheet border when tabsheet was NOT setSizeFull.

Any ideas?

Thanks!
17166.png
17167.png

Looks like it’s a sort of an issue for brand new
Valo
theme.

Everything’s fine for
Reindeer
theme: see attached
reindeer_ts_sizefull_border.png
and
reindeer_ts_not_sizefull_border.png
.

17201.png
17202.png

The Firebug shows that when
tabsheet.setSizeFull()
, an incorrect value is set for
v-tabsheet-content-framed
style="
height
“, which is
less
(but should be equal, at least) than it’s child’s
v-tabsheet-tabsheetpanel
style=”
height
" (see attachment: 98px < 99px). Again, it looks like it is an issue only for the new
Valo
theme, for
Reindeer
theme the correct
height
values are formed
.

17204.png

Hi Vasiley, I have the exact same problem. Were you able to resolve this issue? If so, can you please provide the solution? Did you create a bug on Vaadin to fix this?

Thanks for your time!

Hi Hari,

I haven’t resolved the issue, nor created a bug on Vaadin so far, being switched over to other tasks. It would be very appreciative if you could create this bug on Vaadin by yourself, if you don’t mind, of course.

Cheers!

Thanks Vasiley. I will raise the bug and will post here any updates.

-Hari

.mytheme .v-tabsheet-framed > .v-tabsheet-content > div { border-bottom: 1px solid #dfdfdf; } it should repair problem… i think