Error on table sorting after a filter...

Vaadin 6 / 7 / 8 Framework UI
1

I’ve an error (!) that appears when sorting a table (clicking on a column header).

This error (see below), appears only in the following case :

If I sort my ‘raw’ datas : no problem
If I apply a filter, then click on a column, the error indicator appears beside the table showing the following message :

java.lang.NullPointerException
	at com.vaadin.data.util.DefaultItemSorter.compareProperty(DefaultItemSorter.java:105)
	at com.vaadin.data.util.DefaultItemSorter.compare(DefaultItemSorter.java:67)
	at java.util.Arrays.mergeSort(Arrays.java:1284)
	at java.util.Arrays.mergeSort(Arrays.java:1295)
	at java.util.Arrays.mergeSort(Arrays.java:1295)
	at java.util.Arrays.mergeSort(Arrays.java:1295)
	at java.util.Arrays.mergeSort(Arrays.java:1295)
	at java.util.Arrays.mergeSort(Arrays.java:1295)
	at java.util.Arrays.mergeSort(Arrays.java:1295)
	at java.util.Arrays.mergeSort(Arrays.java:1295)
	at java.util.Arrays.mergeSort(Arrays.java:1295)
	at java.util.Arrays.mergeSort(Arrays.java:1295)
	at java.util.Arrays.mergeSort(Arrays.java:1295)
	at java.util.Arrays.sort(Arrays.java:1223)
	at java.util.Collections.sort(Collections.java:159)
	at com.vaadin.data.util.IndexedContainer.doSort(IndexedContainer.java:1414)
	at com.vaadin.data.util.IndexedContainer.sort(IndexedContainer.java:1394)
	at com.vaadin.ui.Table.sort(Table.java:3044)
	at com.vaadin.ui.Table.sort(Table.java:3066)
	at com.vaadin.ui.Table.changeVariables(Table.java:1896)
	at com.vaadin.terminal.gwt.server.AbstractCommunicationManager.handleVariables(AbstractCommunicationManager.java:1058)
	at com.vaadin.terminal.gwt.server.AbstractCommunicationManager.doHandleUidlRequest(AbstractCommunicationManager.java:559)
	at com.vaadin.terminal.gwt.server.CommunicationManager.handleUidlRequest(CommunicationManager.java:260)
	at com.vaadin.terminal.gwt.server.AbstractApplicationServlet.service(AbstractApplicationServlet.java:438)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:810)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
	at org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
	at org.jboss.web.tomcat.security.SecurityAssociationValve.invoke(SecurityAssociationValve.java:175)
	at org.jboss.web.tomcat.security.JaccContextValve.invoke(JaccContextValve.java:74)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
	at org.jboss.web.tomcat.tc5.jca.CachedConnectionValve.invoke(CachedConnectionValve.java:156)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
	at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
	at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664)
	at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
	at org.apache.tomcat.util.net.MasterSlaveWorkerThread.run(MasterSlaveWorkerThread.java:112)
	at java.lang.Thread.run(Thread.java:595)

Finally, if I enable the column collapsing and the column reordering, I obtain an ‘internal error’ with red popup…

is this a bug …?

Thanks

ps : I use VAADIN 6.2.1, with the latest eclipse plugin

2

Well… Am I the only one to have this problem ?

In that case I must suppose that I’m doing something wrong…:unsure:

Or maybe it’s related with the datas inside the table ?

3

The internal error is a result of the NullPointerException. The cause of the NPE could be that the container returns “null” instead of a Property object for some propertyId. Set a NullPointerException breakpoint in your IDE and you will see what the cause is. I would guess it has something to do with the container you are using.

4

I’m afraid I need more advices…

I know where’s the problem, but I don’t know how to solve it.
the NPE is caused by the following line :

 protected int compareProperty(Object propertyId, boolean sortDirection,
            Item item1, Item item2) {

        // Get the properties to compare
        final Property property1 = item1.getItemProperty(propertyId);  <=== THIS ONE
        final Property property2 = item2.getItemProperty(propertyId);

        // Get the values to compare
        final Object value1 = (property1 == null) ? null : property1.getValue();
        final Object value2 = (property2 == null) ? null : property2.getValue();

Because, both item1 and item2 are null… So of course I get a NPE…
But I can’t understand why are they null !

I’m creating myself the container: an indexedContainer. And before going on the sort process, I can see that all my items in the container are Ok (no null…).

So, I’m surely doing something wrong when initializing the container, but I can’t see what…

Do you have any idea or clue for me…?

thanks

5

A good example is always better : please consider the following program :


import com.vaadin.Application;
import com.vaadin.data.Property.ValueChangeEvent;
import com.vaadin.data.util.IndexedContainer;
import com.vaadin.ui.*;

public class Main extends Application {

	IndexedContainer ic = generateContainer();
	Label label = new Label("Hello Vaadin user");
	TextField text = new TextField ("Filter");
	Table table = new Table();

	@Override
	public void init() {
		
		Window mainWindow = new Window("Isis_tri Application");

		text.setImmediate(true);
		table.setContainerDataSource(ic);

		mainWindow.addComponent(label);
		mainWindow.addComponent(text);
		mainWindow.addComponent(table);
		
		text.addListener(ValueChangeEvent.class,this,"changeText");

		setMainWindow(mainWindow);
	}

	public void changeText () {
		ic.removeAllContainerFilters();
		ic.addContainerFilter("Last Name", text.getValue().toString(), true, false);
	}
	
	
	private IndexedContainer generateContainer() {

		String [] fields = { "First Name","Last Name" };

		String[] fnames = { "Peter", "Alice", "Joshua", "Mike", "Olivia",
				"Nina", "Alex", "Rita", "Dan", "Umberto", "Henrik", "Rene",
				"Lisa", "Marge" };
		String[] lnames = { "Smith", "Gordon", "Simpson", "Brown", "Clavel",
				"Simons", "Verne", "Scott", "Allison", "Gates", "Rowling",
				"Barks", "Ross", "Schneider", "Tate" };

		IndexedContainer ic = new IndexedContainer();

		for (String p : fields) {
			ic.addContainerProperty(p, String.class, "");
		}

		for (int i = 0; i < 1000; i++) {
			Object id = ic.addItem();
			ic.getContainerProperty(id, "First Name").setValue(
					fnames[(int) (fnames.length * Math.random())]
);
			ic.getContainerProperty(id, "Last Name").setValue(
					lnames[(int) (lnames.length * Math.random())]
);
		}

		return ic;
	}

}

It is just a text field + a table.
You type a text in the textfield,then the table is filtered with the value typed on the column ‘Last Name’

After doing this, if I try to sort on any column, I get an internal error (see first message).

What am I doing wrong ?

6

Ok, now I see what the problem is and it is a bug in the item sorter. I created
a ticket
 for it.

7

Ok, thanks,

By the way, I get the same error if the resulting container is empty (after applying the filter) .

but I suppose it’s more or less the same case.